Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Calcit/tooling dependencies and regenerates generated artifacts to reflect newer “traits”/implementation patterns, while also migrating the JS package manager setup to Yarn Berry (Yarn 4) with Plug’n’Play.
Changes:
- Bump
@calcit/procsand update Calcit dependency pins (deps.cirru) includingRespo/respo.calcitandcalcit-lang/memof. - Regenerate
compact.cirruwith new trait/impl constructs (deftrait/defimpl/impl-traits) and updated metadata. - Migrate from Yarn v1 lockfile to Yarn Berry lockfile (v8), add Yarn PnP config (
.yarnrc.yml) and include the generated.pnp.loader.mjs.
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updates dependency versions and pins Yarn via packageManager. |
yarn.lock |
Regenerated lockfile in Yarn Berry (v8) format to match Yarn 4. |
deps.cirru |
Updates Calcit toolchain version and dependency pins. |
compact.cirru |
Regenerated compiled/compact artifact with updated trait/impl patterns and metadata. |
.yarnrc.yml |
Enables Yarn Plug’n’Play (nodeLinker: pnp). |
.pnp.loader.mjs |
Adds Yarn-generated ESM loader for PnP resolution. |
.gitignore |
Ignores Yarn-generated .gz state artifacts under .yarn/. |
.gitattributes |
Marks PnP/Yarn artifacts as generated and disables diffs. |
Files not reviewed (1)
- .pnp.loader.mjs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {} (:package |gen-code) | ||
| :configs $ {} (:init-fn |gen-code.main/main!) (:reload-fn |gen-code.main/reload!) (:version |0.0.5) | ||
| {} (:about "|file is generated - never edit directly; learn cr edit/tree workflows before changing") (:package |gen-code) | ||
| :configs $ {} (:init-fn |gen-code.main/main!) (:reload-fn |gen-code.main/reload!) (:version |0.0.6) |
There was a problem hiding this comment.
compact.cirru now reports :version |0.0.6, but package.json is still 0.0.5 (and calcit.cirru also still references 0.0.5). Keeping these versions inconsistent can confuse releases and downstream consumers; consider updating the source-of-truth version(s) and regenerating compact.cirru so they all match.
| :configs $ {} (:init-fn |gen-code.main/main!) (:reload-fn |gen-code.main/reload!) (:version |0.0.6) | |
| :configs $ {} (:init-fn |gen-code.main/main!) (:reload-fn |gen-code.main/reload!) (:version |0.0.5) |
| }, | ||
| "version": "0.0.5" | ||
| "version": "0.0.5", | ||
| "packageManager": "yarn@4.12.0" |
There was a problem hiding this comment.
With packageManager pinned to Yarn 4 and the lockfile moved to the Yarn Berry format (v8) + PnP, environments that run yarn without Corepack (or with a globally installed Yarn 1.x) may fail to install/build. Consider updating CI/dev setup docs (and CI workflows) to explicitly enable Corepack / activate the specified Yarn version before running yarn.
|
|
||
| .pnp* -diff linguist-generated | ||
| .yarn/* -diff linguist-generated | ||
| .yarnrc.yml -diff linguist-generated |
There was a problem hiding this comment.
.gitattributes marks .yarnrc.yml as -diff linguist-generated, which will hide diffs for a small, human-edited config file. Since changes to Yarn configuration can be impactful, consider not disabling diffs for .yarnrc.yml (keep the generated/diff suppression for .pnp*/lockfiles only).
| .yarnrc.yml -diff linguist-generated |
No description provided.